Horizontal Line Threshold #380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on a specific value of y-axis
…d of horizontalYLimit
…eshold is saved in UserPreferenceSlice.ts and could be adjusted through LineChartSettings
…Series to create all ranges (wonder if this approach worked)
…ed the seriesRange settings to accept optional parameter so that the horizontal line is undefined when there's no horizontalYAxis
… for horizontal Y-axis threshold
|
Here I'm only using the useSeriesRange approach, this has a little bit weird thing where you can see the lines of the percentile overlaps and the strokes also got doubled. I will make a new approach after this as discussed, by creating a new series similar to the percentile approach. |
… to the bottom left that is customizable and able to add new menus such as filters, added a horizontal line settings menu that is able to do add, update, delete on horizontal line threshold that is shown on the list.
…d Item, now highlights selected area based on the current selected district and compartment
…threshold input component and code style
…when the store changes
…/ adding a new threshold, improved styling, added some testid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a dynamic horizontal line threshold based on an arbitrary number (user input) on the line chart. Horizontal line will also differ between selected districts and compartments. It will have a custom settings button located somewhere on the chart (now the bottom part). Inputs are very welcome!
Related Issues
#264
Design Decisions
Performance & Quality
Checklist
I, the author of this PR checked the following requirements for good software quality:
I, the reviewer checked the following things: