-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/onboarding #377
Feature/onboarding #377
Conversation
This reverts commit 3aced9a.
…ion in missing files
…docs and fix major bug and also add the possibility to decide how many lines to show in the card when are folded and when are expanded
…nto feature/generalize
… major bug and also add the possibility to decide how many lines to show in the card when are folded and when are expanded
… new components props
…olor not reflecting currently selected scenario after tour is finished
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good. The code quality is very high.
Apart from the comments and suggestions I already made the only other change request would be to suggest, for you to write all comments with a capital letter at the start and if they form a sentence also with a period at the end.
frontend/src/components/OnboardingComponents/TourComponents/TourSteps.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/OnboardingComponents/WelcomeDialog/WelcomeDialog.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/OnboardingComponents/WelcomeDialog/WelcomeDialog.tsx
Outdated
Show resolved
Hide resolved
…improve comments, move illustrations to different folder
Thank you for the positive feedback! I've addressed the comments and suggestions you made. |
Description
This PR is for the development of the Onboarding System for ESID that effectively guides new users through the application's features and helps them become familiar with it.
Related Issues
Design Decisions
The onboarding system is developed with the React joyride library. There is also a welcome modal that is displayed during the user's initial visit which provides an overview of the application through a series of informative slides and illustrations. The onboarding tours are accessible through the information button in the top bar, which makes them available without being intrusive. Users have the flexibility to start, pause, or retake any tour at their own pace. This implementation makes the onboarding experience adaptable for both new and existing users.
Possible alternative implementations were considered, such as creating a one-time static tour that users would go through only during their first visit. However, this approach is less flexible and doesn't allow users to revisit the tours later or learn at their own pace.
Performance & Quality
Checklist
I, the author of this PR checked the following requirements for good software quality:
I, the reviewer checked the following things: