Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and Refactor Scenario Colors #365

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Conversation

JonasGilg
Copy link
Collaborator

Description

This PR fixes the colorazation of scenarios. Previously a scenario card could have the same color as the case data. There are now two helper functions to fetch the correct colors.

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

…into feature/refactor-scenario-colors

# Conflicts:
#	frontend/docs/changelog/changelog-de.md
#	frontend/docs/changelog/changelog-en.md
@JonasGilg JonasGilg added class:bug Something isn't working class:enhancement New feature or request type:web-frontend labels Jun 10, 2024
@JonasGilg JonasGilg requested a review from NXXR June 10, 2024 13:50
@JonasGilg JonasGilg self-assigned this Jun 10, 2024
Copy link

Test Results

39 tests  ±0   39 ✅ ±0   11s ⏱️ -1s
17 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 3df619a. ± Comparison against base commit 3731c3b.

@JonasGilg JonasGilg merged commit d7dd9b8 into develop Jun 13, 2024
8 checks passed
@JonasGilg JonasGilg deleted the feature/refactor-scenario-colors branch June 13, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class:bug Something isn't working class:enhancement New feature or request type:web-frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants