Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make frontend docker config more configurable #281

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

JonasGilg
Copy link
Collaborator

@JonasGilg JonasGilg commented Jul 13, 2023

Description

This PR makes the docker setup for the frontend configurable.

Design Decisions

This PR adds two new configuration variables for the frontend:

  • ESID_PORTS: Defines the ports under which ESID is published.
  • ESID_BRANCH: Gives a distinct name to the created image.

This allows multiple images with multiple ports to be deployed on the same server.

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@JonasGilg JonasGilg self-assigned this Jul 13, 2023
@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Unit Test Results

  1 files  ±0  14 suites  ±0   24s ⏱️ -10s
32 tests ±0  32 ✔️ ±0  0 💤 ±0  0 ±0 
33 runs  ±0  33 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit d69b811. ± Comparison against base commit 0c3edc9.

♻️ This comment has been updated with latest results.

.env.docker Outdated Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
frontend/.env.docker Outdated Show resolved Hide resolved
frontend/docker-compose.yml Outdated Show resolved Hide resolved
@JonasGilg JonasGilg merged commit 7c845b5 into develop Jul 21, 2023
5 checks passed
@JonasGilg JonasGilg deleted the feature/docker-frontend-config branch July 21, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants