Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Different action between model.predict and action_spaces.sample #1197

Closed
4 tasks done
thscowns opened this issue Dec 2, 2022 · 2 comments
Closed
4 tasks done
Labels
documentation Improvements or additions to documentation

Comments

@thscowns
Copy link

thscowns commented Dec 2, 2022

🐛 Bug

different action between model.predict and action_spaces.sample

I defined action space of my custom env by gym.spaces.Discrete(3, start=-1) which action is [-1, 0, 1]

I recognize different action between model(PPO).predict and action_spaces.sample

action_spces.sample -> [-1. 0, 1]
model.predict -> [0, 1, 2]

gym version == 0.26.2

To Reproduce

from stable_baselines3 import PPO
import gym

class CustomEnv(gym.Env):

  def __init__(self):
    super().__init__()
    self.observation_space = gym.spaces.Box(low=-np.inf, high=np.inf, shape=(14,))
    self.action_space = gym.spaces.Discrete(3, start=-1)

  def reset(self):
    return self.observation_space.sample()

  def step(self, action):
    obs = self.observation_space.sample()
    reward = 1.0
    done = False
    info = {}

    return obs, reward, done, info

for i in range(10):
    print('action_space sample=', env.action_space.sample())
model = PPO('MlpPolicy', env, verbose=1)
obs = env.reset()
for i in range(10):
    action, _states = model.predict(obs)
    print('model-predict=', action)
    print(env.action_space.contains(action))
    obs, rewards, done, info = env.step(action)

Relevant log output / Error message

No response

System Info

OS: Windows-10-10.0.22000-SP0 10.0.22000
Python: 3.7.13
Stable-Baselines3: 1.6.2
PyTorch: 1.13.0+cpu
GPU Enabled: False
Numpy: 1.21.5
Gym: 0.26.2

Checklist

  • I have checked that there is no similar issue in the repo
  • I have read the documentation
  • I have provided a minimal working example to reproduce the bug
  • I've used the markdown code blocks for both code and stack traces.
@thscowns thscowns added the bug Something isn't working label Dec 2, 2022
@araffin araffin added documentation Improvements or additions to documentation and removed bug Something isn't working labels Dec 2, 2022
@araffin
Copy link
Member

araffin commented Dec 2, 2022

Hello,
SB3 does not support a start index different from zero so this is expected.
You should also use the branch for gym 0.26 (see doc and #871 ), SB3 master only supports gym 0.21 for now.

Note for myself : we need to update the env checker.

@thscowns
Copy link
Author

thscowns commented Dec 2, 2022

Thanks for replying!

araffin added a commit to carlosluis/stable-baselines3 that referenced this issue Dec 7, 2022
araffin added a commit that referenced this issue Apr 14, 2023
* Fix failing set_env test

* Fix test failiing due to deprectation of env.seed

* Adjust mean reward threshold in failing test

* Fix her test failing due to rng

* Change seed and revert reward threshold to 90

* Pin gym version

* Make VecEnv compatible with gym seeding change

* Revert change to VecEnv reset signature

* Change subprocenv seed cmd to call reset instead

* Fix type check

* Add backward compat

* Add `compat_gym_seed` helper

* Add goal env checks in env_checker

* Add docs on  HER requirements for envs

* Capture user warning in test with inverted box space

* Update ale-py version

* Fix randint

* Allow noop_max to be zero

* Update changelog

* Update docker image

* Update doc conda env and dockerfile

* Custom envs should not have any warnings

* Fix test for numpy >= 1.21

* Add check for vectorized compute reward

* Bump to gym 0.24

* Fix gym default step docstring

* Test downgrading gym

* Revert "Test downgrading gym"

This reverts commit 0072b77.

* Fix protobuf error

* Fix in dependencies

* Fix protobuf dep

* Use newest version of cartpole

* Update gym

* Fix warning

* Loosen required scipy version

* Scipy no longer needed

* Try gym 0.25

* Silence warnings from gym

* Filter warnings during tests

* Update doc

* Update requirements

* Add gym 26 compat in vec env

* Fixes in envs and tests for gym 0.26+

* Enforce gym 0.26 api

* format

* Fix formatting

* Fix dependencies

* Fix syntax

* Cleanup doc and warnings

* Faster tests

* Higher budget for HER perf test (revert prev change)

* Fixes and update doc

* Fix doc build

* Fix breaking change

* Fixes for rendering

* Rename variables in monitor

* update render method for gym 0.26 API

backwards compatible (mode argument is allowed) while using the gym 0.26 API (render mode is determined at environment creation)

* update tests and docs to new gym render API

* undo removal of render modes metatadata check

* set rgb_array as default render mode for gym.make

* undo changes & raise warning if not 'rgb_array'

* Fix type check

* Remove recursion and fix type checking

* Remove hacks for protobuf and gym 0.24

* Fix type annotations

* reuse existing render_mode attribute

* return tiled images for 'human' render mode

* Allow to use opencv for human render, fix typos

* Add warning when using non-zero start with Discrete (fixes #1197)

* Fix type checking

* Bug fixes and handle more cases

* Throw proper warnings

* Update test

* Fix new metadata name

* Ignore numpy warnings

* Fixes in vec recorder

* Global ignore

* Filter local warning too

* Monkey patch not needed for gym 26

* Add doc of VecEnv vs Gym API

* Add render test

* Fix return type

* Update VecEnv vs Gym API doc

* Fix for custom render mode

* Fix return type

* Fix type checking

* check test env test_buffer

* skip render check

* check env test_dict_env

* test_env test_gae

* check envs in remaining tests

* Update tests

* Add warning for Discrete action space with non-zero (#1295)

* Fix atari annotation

* ignore get_action_meanings [attr-defined]

* Fix mypy issues

* Add patch for gym/gymnasium transition

* Switch to gymnasium

* Rely on signature instead of version

* More patches

* Type ignore because of Farama-Foundation/Gymnasium#39

* Fix doc build

* Fix pytype errors

* Fix atari requirement

* Update env checker due to change in dtype for Discrete

* Fix type hint

* Convert spaces for saved models

* Ignore pytype

* Remove gitlab CI

* Disable pytype for convert space

* Fix undefined info

* Fix undefined info

* Upgrade shimmy

* Fix wrappers type annotation (need PR from Gymnasium)

* Fix gymnasium dependency

* Fix dependency declaration

* Cap pygame version for python 3.7

* Point to master branch (v0.28.0)

* Fix: use main not master branch

* Rename done to terminated

* Fix pygame dependency for python 3.7

* Rename gym to gymnasium

* Update Gymnasium

* Fix test

* Fix tests

* Forks don't have access to private variables

* Fix linter warnings

* Update read the doc env

* Fix env checker for GoalEnv

* Fix import

* Update env checker (more info) and fix dtype

* Use micromamab for Docker

* Update dependencies

* Clarify VecEnv doc

* Fix Gymnasium version

* Copy file only after mamba install

* [ci skip] Update docker doc

* Polish code

* Reformat

* Remove deprecated features

* Ignore warning

* Update doc

* Update examples and changelog

* Fix type annotation bundle (SAC, TD3, A2C, PPO, base class) (#1436)

* Fix SAC type hints, improve DQN ones

* Fix A2C and TD3 type hints

* Fix PPO type hints

* Fix on-policy type hints

* Fix base class type annotation, do not use defaults

* Update version

* Disable mypy for python 3.7

* Rename Gym26StepReturn

* Update continuous critic type annotation

* Fix pytype complain

---------

Co-authored-by: Carlos Luis <[email protected]>
Co-authored-by: Quentin Gallouédec <[email protected]>
Co-authored-by: Thomas Lips <[email protected]>
Co-authored-by: tlips <[email protected]>
Co-authored-by: tlpss <[email protected]>
Co-authored-by: Quentin GALLOUÉDEC <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants