Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to index a flat array with two indices #475

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Don't try to index a flat array with two indices #475

merged 6 commits into from
Jan 6, 2025

Conversation

SolarDrew
Copy link
Contributor

@SolarDrew SolarDrew commented Dec 9, 2024 •
edited
Loading

Fixes #470

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #475 will not alter performance

Comparing SolarDrew:repr-fix (5dfa91f) with main (66035ba)

Summary

✅ 11 untouched benchmarks

@Cadair
Copy link
Member

Cadair commented Dec 9, 2024

Under what circumstances do you have not a 2D tiled dataset?

@SolarDrew
Copy link
Contributor Author

Under what circumstances do you have not a 2D tiled dataset?

When you do ds.flat. See #470

@Cadair Cadair enabled auto-merge (squash) January 6, 2025 11:17
@Cadair Cadair merged commit cd50651 into DKISTDC:main Jan 6, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadair Cadair Cadair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiledDataset.flat breaks if not indexed
2 participants
@SolarDrew @Cadair