Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor transfer_complete_datasets for one transfer job #340

Merged
merged 7 commits into from
Sep 11, 2024

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Mar 5, 2024

fixes #339

@Cadair Cadair force-pushed the complete_datasets branch from 755a54d to 85f348f Compare March 5, 2024 13:32
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.55%. Comparing base (265e15d) to head (300fa04).

Current head 300fa04 differs from pull request most recent head 7e2d45a

Please upload reports for the commit 7e2d45a to get more accurate results.

Files Patch % Lines
dkist/net/helpers.py 91.42% 3 Missing ⚠️
dkist/net/globus/transfer.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   97.03%   97.55%   +0.52%     
==========================================
  Files          65       34      -31     
  Lines        4008     2005    -2003     
==========================================
- Hits         3889     1956    -1933     
+ Misses        119       49      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dkist/net/globus/transfer.py Outdated Show resolved Hide resolved
@Cadair Cadair marked this pull request as ready for review March 5, 2024 15:51
@Cadair Cadair force-pushed the complete_datasets branch 2 times, most recently from 2fd4167 to 300fa04 Compare March 6, 2024 09:53
@Cadair Cadair force-pushed the complete_datasets branch 3 times, most recently from 7c868f4 to e5d31a1 Compare June 20, 2024 13:08
This changes it to only do one globus task rather than one per dataset
@Cadair Cadair force-pushed the complete_datasets branch from e5d31a1 to 227344f Compare June 20, 2024 13:22
Copy link

codspeed-hq bot commented Jun 20, 2024

CodSpeed Performance Report

Merging #340 will not alter performance

Comparing Cadair:complete_datasets (451f37d) with main (983c1f1)

Summary

✅ 9 untouched benchmarks

@Cadair Cadair requested a review from SolarDrew June 20, 2024 15:20
Copy link
Contributor

@SolarDrew SolarDrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine 👍

dkist/net/helpers.py Show resolved Hide resolved
@Cadair Cadair merged commit 7f186b5 into DKISTDC:main Sep 11, 2024
21 checks passed
@Cadair Cadair deleted the complete_datasets branch September 11, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transfer_complete_datasets should only start one transfer job per call
2 participants