Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs.rsshub.app is showing desktop site in Firefox Preview #4633

Closed
ksy36 opened this issue Apr 30, 2020 · 5 comments
Closed

docs.rsshub.app is showing desktop site in Firefox Preview #4633

ksy36 opened this issue Apr 30, 2020 · 5 comments

Comments

@ksy36
Copy link

ksy36 commented Apr 30, 2020

Involved route

Visit https://docs.rsshub.app/ in Firefox Preview or in Responsive design mode in Firefox desktop

What is expected?

The mobile version of the site is shown

What is actually happening?

Site loads as mobile at first, but switches to desktop within a second

Additional info (logs errors etc)

We've diagnosed the issue and looks like this is happening due to viewport tag being removed. More information can be found in this comment webcompat/web-bugs#52296 (comment)

@NeverBehave
Copy link
Collaborator

NeverBehave commented Apr 30, 2020

This issue seems to relate to an upstream implementation by VuePress:

https://github.com/vuejs/vuepress/blob/01cd096307b55c920f6eb2eb1af9e0f8f2b153ac/packages/%40vuepress/core/lib/client/root-mixins/updateMeta.js#L62

It looks like the current headers are not kept. Further investigation required.

@NeverBehave
Copy link
Collaborator

NeverBehave commented Apr 30, 2020

vuejs/vuepress#2359

I have successfully reproduced this issue and reporting to the upstream.

Thank you for letting us know lol.

@ksy36
Copy link
Author

ksy36 commented May 1, 2020

Thanks for looking into this :)

@NeverBehave
Copy link
Collaborator

vuejs/vuepress#2332

Looks like this issue has been opened 11 days ago and a fix already provided, but no one does the review.

@NeverBehave
Copy link
Collaborator

status: workaround applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants