[WIP] 8 CV input expander for parameters (Ildaeil, Carla plugin host) #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-L
commented
Dec 12, 2021
plugins/Cardinal/src/Ildaeil.cpp
Outdated
| if (i < fPluginGenericUI->parameterCount && module->leftExpander.module->inputs[i].isConnected()) { | ||
| float scaled_param = (messagesFromExpander[i] + 10.0) * (fPluginGenericUI->parameters[i].max - fPluginGenericUI->parameters[i].min) / (20.0 + fPluginGenericUI->parameters[i].min); | ||
| fPluginGenericUI->values[i] = scaled_param; | ||
| carla_set_parameter_value(module->fCarlaHostHandle, 0, 0, scaled_param); |
There was a problem hiding this comment.
@falkTX I'm unsure about that part, if there's a more elegant way. How does that look to you? From my test and understanding of this module, both ui->values[] and call to carla_set_parameter_value have to be updated to the new value in order to update both the DSP and the UI.
There was a problem hiding this comment.
yeah this should be done in a different way, I will handle it soon
Simon-L
changed the title
added 6 commits
December 13, 2021 14:29
…host too (First plugin in Carla rack can be controlled for now)
falkTX
reviewed
Dec 15, 2021
Simon-L
changed the title
falkTX
force-pushed
the
main
branch
8 times, most recently
from
e0aecb0
to
30134b4
Compare
falkTX
force-pushed
the
main
branch
3 times, most recently
from
971ae2f
to
a9e5b9a
Compare
falkTX
force-pushed
the
main
branch
4 times, most recently
from
e3644fb
to
ae04997
Compare
falkTX
force-pushed
the
main
branch
4 times, most recently
from
f8e7b03
to
24bed60
Compare
falkTX
force-pushed
the
main
branch
3 times, most recently
from
54b0ec1
to
d3b722e
Compare
falkTX
force-pushed
the
main
branch
4 times, most recently
from
a30e278
to
f7a919f
Compare
falkTX
force-pushed
the
main
branch
8 times, most recently
from
0cba0a1
to
80bda51
Compare
falkTX
force-pushed
the
main
branch
4 times, most recently
from
58e55b0
to
52d71a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty basic for now, 8 parameters of the loaded plugin can be automated.
If inputs are connected, the expander "steals" the UI control, if unconnected, the user controls it.
Note that this is a left-side expander.
There has been some discussion about using the more common convention of right side.
I've made it left-side to experiment with the pattern of constructing chains of expanding modules: here this expander adds (parameters) inputs to the left, and future expanders for outputs could use the right side.
TODO:
Mark the parameter visually in the UI when the expander "stole" it.Done in cea5099Notes for future improvements: