Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Mojo #285

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[WIP] Add Mojo #285

wants to merge 12 commits into from

Conversation

TheGuyWhoo
Copy link

Well this builds and the panels are now dark. I took a look at the examples of bidoo and impromptu dark and yeah I don't understand what's going on there so I just made a repo. Cheers.

@falkTX
Copy link
Contributor

falkTX commented Jul 6, 2022

It is a start, but readme and license stuff needs updating too.

@dromer
Copy link
Collaborator

dromer commented Jul 6, 2022

You still have the Atelier submodule there.

Also it would be "better" to do the panel graphic mods in code, rather than forking the repo with modified assets.

@falkTX
Copy link
Contributor

falkTX commented Jul 6, 2022

one step at a time. the PR already gives a head start for these modules, which is nice :)

@TheGuyWhoo
Copy link
Author

I added atelier myself, I thought pull requests were only for the relevant commit? Should I make another repo without Atelier?

I don't understand the necessary code for that and it's really not worth it for me to learn it just to do that.

@falkTX
Copy link
Contributor

falkTX commented Jul 6, 2022

You need to split each pull request per branch, otherwise this pull request gets all the changes.

In any case, Atelier is currently blocked as we did not get permission to use their artwork.

@TheGuyWhoo
Copy link
Author

Okay I removed it.

@TheGuyWhoo
Copy link
Author

I was wondering if I asked dev do include my dark versions in the official modules repo if that would make things easier if he accepted?

@falkTX falkTX force-pushed the main branch 3 times, most recently from e3644fb to ae04997 Compare August 7, 2022 15:25
@falkTX
Copy link
Contributor

falkTX commented Sep 8, 2022

Best to use upstream sources when possible, we can do the dark mode ourselves at runtime.

I checked on this finally, and there is a license issue. Opened a ticket at tomdasilva/Mojo#4
Let's wait for the reply.

@falkTX falkTX changed the title Add Mojo. [WIP] Add Mojo Sep 8, 2022
@falkTX falkTX added the wontfix This will not be worked on label Nov 30, 2022
@falkTX falkTX force-pushed the main branch 8 times, most recently from 0cba0a1 to 80bda51 Compare January 5, 2024 18:44
@rl2939
Copy link
Contributor

rl2939 commented Aug 17, 2024

@falkTX and @dromer, the developer said they have corrected the licensing error tomdasilva/Mojo#4 (comment) .

@dromer
Copy link
Collaborator

dromer commented Aug 17, 2024

@TheGuyWhoo can you update your branch with the latest Cardinal main and Mojo release changes?

You also still need to add to the Readme and License info.

@falkTX falkTX force-pushed the main branch 4 times, most recently from 58e55b0 to 52d71a1 Compare October 6, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants