-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
32bit vst2 : certain modules cause crashes #80
Comments
that is unusual, need to clarify some points:
|
from wikichip.org :: MMX MMX Extension x86-64 64-bit x86
yes, the same modules mentioned above seem to crash the 32bit plugin when loaded up in reaper on my x64 win10 laptop.
Windows 10 Home 32bit. my x64 laptop is running win 10 pro |
ok so it is a problem with the builds, not with the PCs. The 32bit build uses an old compiler, which could be a reason for such crashes. Updating the compiler should fix the issue, I will see what can be done. |
thank you much, you rock! |
Please try one of the latest builds and let me know if they work now |
just tried with 47350ab and unfortunately still getting the same crashes. side note: when unpacking the latest build in windows, getting duplicate filenames with the new extratone modules (ty for adding those btw, the students will love these since all they want to do is make beats): |
These are not duplicate filenames, but it seems windows case-insensitivity is being a PITA? |
This breaks also macOS too since it uses case-sensitive filenames by default. |
just got a chance to try 32bit f998ee2 and am, unfortunately, still getting the crashes with a lot of modules |
I can confirm the crash.
Likely a null pointer de-reference. |
not sure if it would be useful but i have a fairly exhaustive "to avoid" list going now of most all the crashing modules. if for any reason that might be helpful here, let me know. |
Which host are you using? How is the LV2 version for you? |
host doesnt really matter. I can trigger the issues with a compiled standalone. |
This seems to have improved considerably. I was able to load audible, mindmeld and valleyaudio stuff on a win32 build. Also noticed the knobs do not move, an issue we had previously due to NaNs being converted to 0. So the first Cardinal release will be out without this fixed, but at least there is some ideas on things to investigate. |
i'm still using an older 32bit (pre vortico/as modules removal), and tbh most of the modules still work great. am super grateful to have vcv pro 2 in any capacity running via 32bit! not sure if it's useful, i made a list of the following that cause crashes (sadly, a lot of the good vcos/vcfs are in this list) - however all other modules outside this list afaik work great. will try out cardinal again when it's fully released and update this list:: *crashes when clicking on the module in the browser amalgamated: autinn ** audible: befaco: bidoo: bog: chowdsp: e-series hetrick: mindmeld shapemaster works for the most part but crashes when using the crossover/lp/hp filters valley zzc: |
p.s. all the knobs seem to work fine for me afaik... again, am running an older build so not sure about the latest builds. |
It is already tagged and released. Such list for the old builds is not that useful, since many core things have changed. |
gotcha that makes total sense will certainly re test when i can |
had a chance to check out the ones on my list in reaper with the win32-22.02 build and everything on that list is still valid/causing crashes. removed the befaco/vortico ones. added autinn as they are causing crashes on project reload sometimes. |
ah damn, I was hoping things would be better now :( |
Good news, I was able to fix most of these issues. Seems the crashes were related to memory alignment, where 64bit OSes do it automatically as needed, but for 32bit ones we need to force it. From the ones on your list that cause crashes on load I only now have ValleyAudio stuff still crashing, the other ones load and seem to work fine. |
awesome! tyty will check this latest build out today when i can :) |
had a chance to go through the list (as well as the new additions since that list was created)... everything seems to work now except two chow dsp ones on the list: chorus - still crashes on load, and the weiner filter still crashes when you reload a project with it in there. really loving having access to all these new filters/oscillators now, so ty for those fixes!!! |
Related to #80 Signed-off-by: falkTX <[email protected]>
FYI Fundamental wavetable modules (WTVCO and WTLFO) were crashing on win32, fixed on latest builds, will be part of 22.06 and btw, Fundamental has 2 new modules, should we try a reskin for those? |
awesome for the fix and yes, will whip up some svgs for those very soon |
super stoked about these new mindmeld and stoermelder modules! bravo!! noticing however that the latest 32bit vst2 (build #1309) is crashing right when i try to load it in both reaper and or ableton 32bit |
I have a suspicion of what is going on. only vst2 crashes, right? both vst3 and clap work under reaper, right? |
also, just rebooted and very first thing loaded reaper then the vst3 and received a crash (although didn't crash when i loaded the vst3 after opening reaper a 2nd time) |
i'm also noticing that the 32bit vst2 cardinal midi host module -midi out- isn't working in 22.10 or 22.11 (and one of the latest stoermelder builds) but seems to work okay in 22.09. not sure if it's related to any of the vst2 issues above. if not i can make a new ticket if you think that best. |
@offthesky do you mind retrying some of your breaking patches on the latest release? |
i dont see any mention in the changelist for 32b fixes w the 23.09 rls. once falktx mentions in this thread he's tried to fix something, i'll gladly retest all the diff plugin types when i have time. but until then, holding off. if you want to try 23.09 in reaper 32b, please do- whenever i've tested in the past i just try using the built in demo patches. they either crash on load or when reloading the saved project. often the default start patch (host midi>vcv vco>vcv adsr>vcv vca>host audio) crashes right when loading the plugin. many of the stock vcv ones crash on load. thankfully for now, the (mostly) stable 22.09 32b still work very well |
It's more that it has been quite a long time since you tested and I think the builds have been adjusted in the mean time (no more LTO on release builds, for instance). Still worth to confirm that things are broken for you. I do not have any 32bit windows systems that I could test this on. |
haven't tested them all yet but here are ones that consistently crash when trying to load them:
audible: liquid filter, eq filter
amalgamated: d'acchord
befaco: even vco
e series: cloud generator
mind meld: none of these work
vortico: vco, wt vco, lfo, wt lfo, vcf, sometimes adsr (or, it will let you load adsr and then the project will crash upon reopen. which is the case for several others)
Valley, all their oscillators and feline
seems polyphony is a common denominator.
of course no issues in win x64 (am testing this out in 32bit since i teach classes for kids in a place that still has 32bit pcs)
The text was updated successfully, but these errors were encountered: