Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code out of __init__ files #352

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aldbr
Copy link
Contributor

@aldbr aldbr commented Dec 19, 2024

Part of #268

@chrisburr chrisburr force-pushed the main_FEAT_move-bl-from-init branch 3 times, most recently from 42afcc4 to 0984a06 Compare December 20, 2024 13:27
@chrisburr chrisburr changed the title feat(diracx): move bl from __init__ files Move code out of __init__ files Dec 20, 2024
@chrisburr chrisburr force-pushed the main_FEAT_move-bl-from-init branch 3 times, most recently from d0402ec to c849ead Compare December 20, 2024 15:17
@chrisburr chrisburr force-pushed the main_FEAT_move-bl-from-init branch from c849ead to c9a8349 Compare December 20, 2024 15:22
@chrisburr chrisburr marked this pull request as ready for review December 20, 2024 15:23
@@ -0,0 +1,142 @@
# Can't using PEP-604 with typer: https://github.com/tiangolo/typer/issues/348
# from __future__ import annotations
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Suggested change
# from __future__ import annotations

@@ -0,0 +1,142 @@
# Can't using PEP-604 with typer: https://github.com/tiangolo/typer/issues/348
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue has been closed in August, so we can probably remove this comment now?

Suggested change
# Can't using PEP-604 with typer: https://github.com/tiangolo/typer/issues/348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant