Add /auth/legacy-exchange #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisburr
force-pushed
the
legacy-exchange
branch
from
bb66eb9 to
45347e0
Compare
chrisburr
force-pushed
the
legacy-exchange
branch
from
45347e0 to
102a6ed
Compare
|
Looks like it breaks in the way we expected at least 🤞 |
chrisburr
force-pushed
the
legacy-exchange
branch
3 times, most recently
from
a9d50e9 to
afbd9a6
Compare
chrisburr
commented
Sep 27, 2023
.github/workflows/integration.yml
Outdated
Comment on lines
45
to
50
| - name: diracx logs | ||
| if: ${{ failure() }} | ||
| run: docker logs diracx | ||
| - name: DIRAC logs | ||
| if: ${{ failure() }} | ||
| run: cd /tmp/DIRACRepo && ./integration_tests.py logs --no-follow --lines 1000 |
There was a problem hiding this comment.
This makes things much nicer for debugging: https://github.com/DIRACGrid/diracx/actions/runs/6328508346/job/17186827358
chrisburr
force-pushed
the
legacy-exchange
branch
6 times, most recently
from
6340c92 to
eacb66d
Compare
chrisburr
commented
Sep 29, 2023
.github/workflows/integration.yml
Outdated
| @@ -30,7 +30,7 @@ jobs: | |||
| - name: Prepare environment | |||
| run: | | |||
| pip install typer pyyaml gitpython packaging | |||
| git clone https://github.com/DIRACGrid/DIRAC.git -b "${{ matrix.dirac-branch }}" /tmp/DIRACRepo | |||
| git clone https://github.com/chaen/DIRAC.git -b "diracx_sandbox" /tmp/DIRACRepo | |||
There was a problem hiding this comment.
@chaen This is also ready for review modulo this change which will be reverted before merging
There was a problem hiding this comment.
👍 I've added just the 2 minor fixes we needed (location for write_credentials and DiracClient taking a Pref object)
chaen
force-pushed
the
legacy-exchange
branch
from
98382ae to
ccdd772
Compare
chrisburr
force-pushed
the
legacy-exchange
branch
from
ccdd772 to
263e0c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs DIRACGrid/DIRAC#7222