Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minio #8

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Add minio #8

merged 3 commits into from
Aug 31, 2023

Conversation

chrisburr
Copy link
Member

@chrisburr chrisburr commented Jun 30, 2023

This adds minio to the chart. It's exposed to the host using two node ports which isn't ideal but it probably the nicest thing for development to avoid needing to play with DNS resolution (minio doesn't support running on anything other than /).

@chaen
Copy link
Contributor

chaen commented Jun 30, 2023

Are you sure it doesn't work through ingress ? This problem seems to have been fixed with minio/console#2818

.gitignore Outdated Show resolved Hide resolved
@fstagni fstagni marked this pull request as draft July 5, 2023 12:23
@chrisburr
Copy link
Member Author

Are you sure it doesn't work through ingress ? This problem seems to have been fixed with minio/console#2818

I had tried but I didn't manage and thought I had read that it was only possible for the console and not for the main S3-compatible API endpoint. That said, I'd be very happy to be wrong 😄

@chaen
Copy link
Contributor

chaen commented Jul 17, 2023

I had quite a play with this, and although I managed to make it work with the ingress and some caveats, I think that for the time being, we should indeed stick to the node port for local development.

The reason is that the best way to make it work is to expose extra ports in the ingress (9000 and 9001) for example. And this can be done (see for example https://gitlab.cern.ch/lhcb-dirac/diracchart/-/blob/master/charts/dirac/values.yaml#L200-231)
However, when running locally with kind, we do not manage the ingress with helm, so you can't update it with helm. So it probably isn't worth the trouble.
We may however keep that solution in mind for production configuration

@chrisburr chrisburr marked this pull request as ready for review July 26, 2023 06:57
@chrisburr
Copy link
Member Author

I think the way to go is with node port for development and SNI for production.

@chrisburr chrisburr merged commit bc03d74 into DIRACGrid:master Aug 31, 2023
@chrisburr chrisburr deleted the add-minio branch August 31, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants