Question: Tags/RequiredTags added twice to pilot.cfg

[aldbr]

Not a real issue, just a question related to DIRACGrid/DIRAC#7086

Tags/RequiredTags are added both in /LocalSite and /Resources/Computing/CEDefaults. Is that expected?

See here:

Pilot/Pilot/pilotCommands.py

Lines 565 to 568 in 15a0874

	for queueParamName, queueParamValue in self.pp.queueParameters.items():
	if isinstance(queueParamValue, list): # for the tags
	queueParamValue = ",".join([str(qpv).strip() for qpv in queueParamValue])
	self.cfg.append("-o /LocalSite/%s=%s" % (queueParamName, quote(queueParamValue)))

And here:

Pilot/Pilot/pilotCommands.py

Lines 679 to 687 in 15a0874

	self.pp.tags = list(set(self.pp.tags))
	if self.pp.tags:
	self.cfg.append('-o "/Resources/Computing/CEDefaults/Tag=%s"' % ",".join((str(x) for x in self.pp.tags)))
	self.pp.reqtags = list(set(self.pp.reqtags))
	if self.pp.reqtags:
	self.cfg.append(
	'-o "/Resources/Computing/CEDefaults/RequiredTag=%s"' % ",".join((str(x) for x in self.pp.reqtags))
	)

Thanks

[fstagni]

Looks to me that they are only added in

Pilot/Pilot/pilotCommands.py

Lines 679 to 687 in 15a0874

	self.pp.tags = list(set(self.pp.tags))
	if self.pp.tags:
	self.cfg.append('-o "/Resources/Computing/CEDefaults/Tag=%s"' % ",".join((str(x) for x in self.pp.tags)))
	self.pp.reqtags = list(set(self.pp.reqtags))
	if self.pp.reqtags:
	self.cfg.append(
	'-o "/Resources/Computing/CEDefaults/RequiredTag=%s"' % ",".join((str(x) for x in self.pp.reqtags))
	)

??

[aldbr]

self.pp.tags is created from resourceDict here:

Pilot/Pilot/pilotCommands.py

Line 576 in 15a0874

self.pp.tags += resourceDict["Tag"]

And self.pp.queueParameters is also created from resourceDict and then used to feed self.cfg with /LocalSite options:

Pilot/Pilot/pilotCommands.py

Lines 564 to 568 in 15a0874

	self.pp.queueParameters = resourceDict
	for queueParamName, queueParamValue in self.pp.queueParameters.items():
	if isinstance(queueParamValue, list): # for the tags
	queueParamValue = ",".join([str(qpv).strip() for qpv in queueParamValue])
	self.cfg.append("-o /LocalSite/%s=%s" % (queueParamName, quote(queueParamValue)))

Am I wrong?

[fstagni]

Bof, anyway the 2 locations are rather equivalent, so leave 1 only (none of them is obviously better than the other)