Pilot tags are ignored if /Resources/Sites/{grid_type}/{site}/CEs/{ce_name}/Queues/Tag is set

[chrisburr]

In the pilot there are two places that the Tag field can be set:

1. /LocalSite/Tag is set here: https://github.com/DIRACGrid/Pilot/blob/15a0874e520a83243aee2fdcec20a87ccc1328d6/Pilot/pilotCommands.py#L565-L568
2. /Resources/Computing/CEDefaults/Tag is set here: https://github.com/DIRACGrid/Pilot/blob/15a0874e520a83243aee2fdcec20a87ccc1328d6/Pilot/pilotCommands.py#L680-L681

This results in a pilot.cfg like:

LocalSite
{
  Tag = Token
}
Resources
{
  Computing
  {
    CEDefaults
    {
      Tag = /cvmfs/unpacked.cern.ch/
      Tag += /cvmfs/cernvm-prod.cern.ch/
      Tag += Token
      Tag += /cvmfs/lhcbdev.cern.ch/
      Tag += /cvmfs/lhcb.cern.ch/
      Tag += /cvmfs/lhcb-condb.cern.ch/
    }
  }
}

This is then loaded here:

DIRAC/src/DIRAC/Resources/Computing/ComputingElement.py

Lines 140 to 159 in 4b5a821

	# Collect global defaults first
	for section in ["/Resources/Computing/CEDefaults", f"/Resources/Computing/{self.ceType}"]:
	result = gConfig.getOptionsDict(section)
	self.log.debug(result)
	if result["OK"]:
	ceOptions = result["Value"]
	for key in ceOptions:
	if key in INTEGER_PARAMETERS:
	ceOptions[key] = int(ceOptions[key])
	if key in FLOAT_PARAMETERS:
	ceOptions[key] = float(ceOptions[key])
	if key in LIST_PARAMETERS:
	ceOptions[key] = gConfig.getValue(os.path.join(section, key), [])
	self.ceParameters.update(ceOptions)
	# Get local CE configuration
	localConfigDict = getCEConfigDict(self.ceName)
	self.ceParameters.update(localConfigDict)

/LocalSite/Tag takes priority resulting in the per pilot tags being ignored:

In[1]: import DIRAC
  ...: DIRAC.initialize(extra_config_files=["pilot.cfg"])
  ...: 
  ...: from DIRAC.Core.Utilities.ReturnValues import returnValueOrRaise
  ...: from DIRAC.Resources.Computing.ComputingElementFactory import ComputingElementFactory
  ...: ceFactory  = ComputingElementFactory()
  ...: ce = returnValueOrRaise(ceFactory.getCE("Singularity"))
  ...: ce.initializeParameters()
  ...: returnValueOrRaise(ce.getDescription())
Out[1]:
{'InstallDIRACInContainer': 'False',
 'Tag': 'Token',
 'FileCatalog': 'FileCatalog'}

Related, it looks like getCEConfigDict is buggy and doesn't consider INTEGER_PARAMETERS/FLOAT_PARAMETERS/LIST_PARAMETERS.