[8.0] Avoid locking in MessageQueueHandler #7964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIRACGridBot
added
the
alsoTargeting:integration
chaen
approved these changes
Dec 20, 2024
DIRACGridBot
added
the
sweep:done
DIRACGridBot
pushed a commit
to DIRACGridBot/DIRAC
that referenced
this pull request
Dec 20, 2024
|
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/12430060530 Successful:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
logging.Handlercpython suggests having a lock on thehandlemethod to avoid multiple lines being emitted at the same time and corrupting the output.For the
MessageQueueHandlerthis isn't actually a concern and it actually just becomes a source of lock contention.BEGINRELEASENOTES
*Core
FIX: Avoid locking in MessageQueueHandler
ENDRELEASENOTES