[sweep:integration] feat (TS): add getTransformationFilesAsJsonString #7843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIRACGridBot
requested review from
andresailer,
fstagni and
atsareg
as code owners
chrisburr
previously requested changes
Oct 17, 2024
fstagni
force-pushed
the
cherry-pick-2-5db2e0abe-integration
branch
2 times, most recently
from
1bb470e to
931b87f
Compare
chrisburr
reviewed
Nov 6, 2024
| @@ -634,12 +633,7 @@ def getTransformationFiles( | |||
|
|
|||
| resultList = [dict(zip(columns, row)) for row in res["Value"]] | |||
|
|
|||
| result = S_OK(resultList) | |||
| if include_web_records: | |||
| webList = [[str(item) if not isinstance(item, int) else item for item in row] for row in res["Value"]] | |||
There was a problem hiding this comment.
Can you remove this from the tasks as well
|
Otherwise looks good |
fstagni
force-pushed
the
cherry-pick-2-5db2e0abe-integration
branch
from
931b87f to
25a36c1
Compare
chrisburr
reviewed
Nov 6, 2024
fstagni
force-pushed
the
cherry-pick-2-5db2e0abe-integration
branch
from
25a36c1 to
07c8360
Compare
fstagni
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sweep #7840
feat (TS): add getTransformationFilesAsJsonStringtointegration.Adding original author @chaen as watcher.
BEGINRELEASENOTES
*Core
FIX: Returning DISET responses with >100000000 bytes
*Transformation
NEW: Use getTransformationFilesAsJsonString for faster getTransformationFiles
ENDRELEASENOTES