[8.0] fix: close open file #7651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIRACGridBot
added
the
alsoTargeting:integration
chaen
reviewed
Jun 6, 2024
| @@ -71,6 +71,7 @@ def sendFile(self, filename, fileId, token=""): | |||
| retVal = transport.receiveData() | |||
| return retVal | |||
| finally: | |||
| fileHelper.oFile.close() | |||
There was a problem hiding this comment.
I tried to follow down the list of calls and seems like it is set. Given the fact that the integration tests pass, we can be a bit confident that it is indeed set. But if you prefer, I put it in a try...except clause.
There was a problem hiding this comment.
It's only ever created in case the first argument of getFileDescriptor is a string, which is always true here, so you can forget my comment !
DIRACGridBot
added
the
sweep:done
DIRACGridBot
pushed a commit
to DIRACGridBot/DIRAC
that referenced
this pull request
Jun 10, 2024
|
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/9446730190 Successful:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7641
BEGINRELEASENOTES
*Framework
FIX: close open file (DISET!)
ENDRELEASENOTES