[v8.0] fix: AREX out and err need to exist before file integrity check #7588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIRACGridBot
added
the
alsoTargeting:integration
andresailer
reviewed
Apr 22, 2024
| @@ -898,10 +898,8 @@ def getJobOutput(self, jobID, workingDirectory=None): | |||
| if remoteOutput == f"{stamp}.out": | |||
| with open(localOutput) as f: | |||
| stdout = f.read() | |||
| os.unlink(localOutput) | |||
There was a problem hiding this comment.
But it is possible that we are not using the RemoteRunner with AREX, right? So who cleans up these files then?
There was a problem hiding this comment.
Indeed, the PilotManager is also using <CE>.getJobOutput() and removes the WorkingDirectory (containing the outputs) at the end of the operation:
I agree that this is not ideal, but IIUC, at some point, pilots will report their outputs by themselves and I guess that the getJobOutput method would only be used for such a use case(?).
There was a problem hiding this comment.
OK, then there is no problem!
fstagni
approved these changes
Apr 22, 2024
DIRACGridBot
added
the
sweep:done
DIRACGridBot
pushed a commit
to DIRACGridBot/DIRAC
that referenced
this pull request
Apr 22, 2024
… integrity check
|
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/8786397925 Successful:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Solution introduced in #7549 does not work:
RemoteRunner._checkOutputIntegrity()checks the integrity of the output, but the.outand.errfiles are removed by theAREXCEbefore being checked. Therefore, the output is considered corrupted.Here we remove the
.outand.errin theRemoteRunnerafter the integrity check, following theAREXCEformat. I don't think it is a problem because:RemoteRunnerworks only withAREX/ARCCEsRemoteRunneris going to disappear at some point.BEGINRELEASENOTES
*WorkloadManagement
FIX: AREX "out" and "err" need to exist before file integrity check
ENDRELEASENOTES