Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] fix(Workflow): prevent circular import in WorkflowReader #7575

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

andresailer
Copy link
Contributor

I am not sure why I never tried this before...

python -c "from DIRAC.Core.Workflow.WorkflowReader import WorkflowXMLHandler"

fails all by itself.

I think in readthedocs we hit some race condition, because that treats source files in parallel.
Because this works

python -c "from DIRAC.Core.Workflow import Workflow; from DIRAC.Core.Workflow.WorkflowReader import WorkflowXMLHandler"

BEGINRELEASENOTES

*WMS
FIX: Fix potential circular import in WorkflowReader. Mostly seen in the creation of the documentation.

ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Apr 17, 2024
@fstagni fstagni merged commit 6e51ed7 into DIRACGrid:rel-v8r0 Apr 18, 2024
25 checks passed
@DIRACGridBot DIRACGridBot added the sweep:done All sweeping actions have been done for this PR label Apr 18, 2024
DIRACGridBot pushed a commit to DIRACGridBot/DIRAC that referenced this pull request Apr 18, 2024
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/8734177845

Successful:

  • integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants