-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0] Fix memory reporting #7518
Conversation
@@ -847,9 +827,9 @@ def __getUsageSummary(self): | |||
if "MemoryUsed" in self.parameters: | |||
memory = self.parameters["MemoryUsed"] | |||
if memory: | |||
summary["MemoryUsed(kb)"] = abs(float(memory[-1]) - float(self.initialValues["MemoryUsed"])) | |||
summary["MemoryUsed(mb)"] = abs(float(memory[-1]) - float(self.initialValues["MemoryUsed"])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that computing the MemoryUsed as the difference between the last measured value of RSS and the initial value is fine in most of the cases. However it seems to me that it does not take into account eventual peaks of memory usage during the program execution. So I'm wondering if it wouldn't make sense to add another parameter "PeakMemoryUsed" or "MaxMemoryUsed".
Anyway this could go in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can propose this in a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok fine for me. I will not do it immediately but I keep it in mind.
To be consistent I suggest that we use MB also for the Memory parameter. |
d9753c2
to
ce4ee93
Compare
ce4ee93
to
7d0f76d
Compare
7d0f76d
to
27f2f18
Compare
I've just added an "approve" review but I see thate Merging is still blocked. |
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/8329879707 Failed:
|
After #7509
BEGINRELEASENOTES
*WMS
FIX: Fix memory reporting
ENDRELEASENOTES