[8.0] fix(JobStateUpdate): for staging, make sure the jobID is an integer #7378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If jobID is not an integer, we never get a correct result, because the dictionary key is converted to an int, and then the string is not found and we do not get the attribute value back.
DIRACGridBot
added
the
alsoTargeting:integration
fstagni
approved these changes
Dec 20, 2023
DIRACGridBot
added
the
sweep:done
DIRACGridBot
pushed a commit
to DIRACGridBot/DIRAC
that referenced
this pull request
Dec 20, 2023
… jobID is an integer
|
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/7276918369 Successful:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If jobID is not an integer, we never get a correct result, because the dictionary key is converted to an int,
DIRAC/src/DIRAC/WorkloadManagementSystem/DB/JobDB.py
Line 237 in 255b146
and then the string jobID is not found
DIRAC/src/DIRAC/WorkloadManagementSystem/DB/JobDB.py
Line 255 in 255b146
and we do not get the attribute value back
DIRAC/src/DIRAC/WorkloadManagementSystem/Service/JobStateUpdateHandler.py
Line 75 in 255b146
BEGINRELEASENOTES
FIX: The callback for the Stager was failing, because of a type mismatch in the jobID used to retrieve the status. Jobs never came out of Staging.
ENDRELEASENOTES