Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Improve performance of job delete/kill/reschedule API #7317

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

sfayer
Copy link
Member

@sfayer sfayer commented Nov 28, 2023

Hi,

This adds a filter for checking the job states in the delete/kill/reschedule API to allow them to run in bulk as discussed in #7314.

I'm not sure the old checkJobStateTransition is actually used any more, but I've left it there in-case someone else is using it.

Closes #7314

BEGINRELEASENOTES
*Interfaces
FIX: Improve performance of job delete/kill/reschedule API
ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Nov 28, 2023
@fstagni
Copy link
Contributor

fstagni commented Nov 28, 2023

It's probably OK to also set checkJobStateTransition as deprecated then.

@sfayer
Copy link
Member Author

sfayer commented Nov 28, 2023

It's probably OK to also set checkJobStateTransition as deprecated then.

Sure, I've added that now.

fstagni
fstagni previously approved these changes Nov 28, 2023
@fstagni fstagni merged commit af3b2b3 into DIRACGrid:rel-v8r0 Nov 29, 2023
24 checks passed
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Nov 29, 2023
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/7031089999

Failed:

  • integration
    cherry-pick af3b2b3 into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-af3b2b349-integration
    git cherry-pick -x -m 1 af3b2b349
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #7317 Improve performance of job delete/kill/reschedule API' --author='Simon Fayer <[email protected]>'
    git push -u origin cherry-pick-2-af3b2b349-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] Improve performance of job delete/kill/reschedule API' \
         --body 'Sweep #7317 `Improve performance of job delete/kill/reschedule API` to `integration`.
    
    Adding original author @sfayer as watcher.
    
    BEGINRELEASENOTES
    *Interfaces
    FIX: Improve performance of job delete/kill/reschedule API
    ENDRELEASENOTES
    Closes #7325'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants