-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0] Job parameters: use only OpenSearch #7292
Conversation
17a570d
to
2a4c139
Compare
2a4c139
to
387f474
Compare
a8b07ce
to
3072e6f
Compare
3072e6f
to
210754b
Compare
src/DIRAC/WorkloadManagementSystem/DB/ElasticJobParametersDB.py
Outdated
Show resolved
Hide resolved
I would have also a related but more general question about index prefix naming. |
We normally use different OpenSearch instances for different DIRAC setups (same as we do not mix MySQL databases). |
464f248
to
4b9ff30
Compare
3944d76
to
f7d5702
Compare
) | ||
if not result["OK"]: | ||
return result | ||
self.elasticJobParametersDB = result["Value"]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that try/except for RuntimeError that was there before, really no longer needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ElasticJobParametersDB still throws RuntimeError
e.g.:
https://github.com/DIRACGrid/DIRAC/pull/7292/files#diff-343b190022086de54ccf30f9a1ae0e7b1c5f5b312f95f48e9c91abf17f210dbaR43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it's ObjectLoader().loadObject()
that should catch that. Do you agree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the throwing comes from calling the c'tor of ElasticJobParametersDB in this line here, doesn't it?
self.elasticJobParametersDB = result["Value"]()
^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. But, anyway, this is initialize()
and it's OK to see the exception, if it happens.
f7d5702
to
504630a
Compare
src/DIRAC/WorkloadManagementSystem/DB/ElasticJobParametersDB.py
Outdated
Show resolved
Hide resolved
504630a
to
d54a3d4
Compare
BEGINRELEASENOTES
*WMS
CHANGE: only use Elastic/OpenSearch for storing JobParameters
CHANGE: ElasticJobParameters index new names: JobParameters_indexSplt
ENDRELEASENOTES