fix: disabledVOs not available when doing dirac-configure #7284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldbr
changed the title
|
We already do it a second time so I think this makes sense as there is the same problem with adding VOMS extensions and uploadijng the proxy: |
chrisburr
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"chicken and egg" situation here.
When doing
dirac-configure, the CS is not yet available to the user, so we cannot get the VO and theDisabledVOsvalue.Therefore,
DisabledVOsis equal to[]and the condition is alwaysTrue, which triggers calls todiracx, which is not available.I proposed the following "hack" to perform the DIRAC hackathon.
The problem with that approach is that you would need to perform
dirac-proxy-initagain, afterdirac-configure, to get a token along with a proxy.BEGINRELEASENOTES
*Framework
FIX: disabledVOs not available when doing dirac-configure
ENDRELEASENOTES