Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] fix: SiteDirector acts for a VO #7263

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

fstagni
Copy link
Contributor

@fstagni fstagni commented Oct 31, 2023

BEGINRELEASENOTES

*WMS
FIX: SiteDirector acts for a VO

ENDRELEASENOTES

@fstagni fstagni requested a review from atsareg as a code owner October 31, 2023 11:37
aldbr
aldbr previously approved these changes Nov 7, 2023
Copy link
Contributor

@aldbr aldbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question: can we have a VO without any group? If no, I guess we might also remove conditions around self.voGroups such as

@fstagni
Copy link
Contributor Author

fstagni commented Nov 7, 2023

Thanks for pointing that out. I actually think that self.voGroups was a hack, as written in the comment in the code. So, I removed it now that we can run per VO. CC @atsareg

@fstagni fstagni merged commit 8de5107 into DIRACGrid:integration Nov 7, 2023
22 checks passed
@DIRACGridBot DIRACGridBot added the sweep:ignore Prevent sweeping from being ran for this PR label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep:ignore Prevent sweeping from being ran for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants