Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] Support selecting legacy adaptor client #7258

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

chrisburr
Copy link
Member

@chrisburr chrisburr commented Oct 26, 2023

This PR adds the ability to enable the DiracX backend for RPC calls in a specific client by setting /DiracX/LegacyClientEnabled/SYSTEM_NAME/SERVICE_NAME in the CS. The existing DIPS/Tornado client selector logic is then used to conditionally redirect RPC calls to the diracxClient class property of the client.

This PR also modified the CS to switch from an EnabledVOs list to a DisabledVOs list for specifying which Virtual Organizations (VOs) should not use DiracX via the legacy compatibility mechanism. This better reflects how having DiracX enabled is a temporary thing during the deployment of DIRAC v9.

Closes #7188
Closes DIRACGrid/diracx#154

BEGINRELEASENOTES

*Core
NEW: Support using DiracX as a backend for RPC calls

ENDRELEASENOTES

@chrisburr chrisburr force-pushed the legacy-adaptor-selector branch from 96294ad to 0d72a7d Compare October 30, 2023 03:43
@chrisburr chrisburr force-pushed the legacy-adaptor-selector branch 5 times, most recently from 2e7fbee to c2f9472 Compare November 1, 2023 16:06
@chrisburr chrisburr force-pushed the legacy-adaptor-selector branch from c2f9472 to e18eb7c Compare November 1, 2023 16:49
@chrisburr chrisburr marked this pull request as ready for review November 2, 2023 05:18
@chrisburr
Copy link
Member Author

@fstagni As you marked the conversation as resolved, are you happy to merge?

@fstagni fstagni merged commit e87844d into DIRACGrid:integration Nov 3, 2023
22 checks passed
@DIRACGridBot DIRACGridBot added the sweep:ignore Prevent sweeping from being ran for this PR label Nov 3, 2023
@chrisburr chrisburr deleted the legacy-adaptor-selector branch November 5, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep:ignore Prevent sweeping from being ran for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change enabled VOs to disabled VOs for DiracX Move DIRAC_ENABLE_DIRACX_LOGIN to the CS
3 participants