[8.0]: TransformationCleaningAgentL fix two exceptions in CleanWithRMS #7242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix error when trying to access res['Value']
fix exception about missing encoding
DIRACGridBot
added
the
alsoTargeting:integration
andresailer
removed
the
alsoTargeting:integration
fstagni
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually tested this now, and found some issues.
Also included in the swept PR #7239 already.
BEGINRELEASENOTES
*TS
FIX: TransformationCleaningAgent: fix two exceptions for CleanWithRMS: encoding before hashing, accessing res["Value"]["Failed"] when Value is None
ENDRELEASENOTES