Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] feat: pilot submission with tokens in a multi-VO setup #7208

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

aldbr
Copy link
Contributor

@aldbr aldbr commented Sep 19, 2023

Aims at solving #7207
This is the implementation of the second solution.

Pros: very easy to implement as you can see
Cons: it does not work if a given CE accepts tokens from VO "A" but not from VO "B", while they are both ready to use tokens. Can it happen?

BEGINRELEASENOTES
*WorkloadManagement
CHANGE: pilot submission with tokens in a multi-VO context
ENDRELEASENOTES

@aldbr aldbr requested a review from marianne013 September 19, 2023 08:00
@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Sep 19, 2023
@aldbr aldbr changed the title [8.0] feat pilot sub with token multi vo [8.0] feat: pilot submission with tokens in a multi-VO setup Sep 19, 2023
@aldbr aldbr force-pushed the v8.0_FEAT_PilotSubWithTokenMultiVO branch from f930eab to 077979e Compare September 22, 2023 16:38
@aldbr
Copy link
Contributor Author

aldbr commented Oct 19, 2023

I changed the approach.
Now you can specify Tag = Token:<VO> to make sure that only a given set of VO will use tokens in a CE.

Pros: very easy to implement as you can see, DIRAC sysadmins keep control of what is done.
Cons: needs a lot of actions from the DIRAC sysadmins.

There was another approach requiring no change of the code, which would have consisted in copying each queue (one with Tag = Token, the other without it). The approach was consistent but hard to manage, @marianne013 and I decided not to go through this path.

Copy link
Contributor

@marianne013 marianne013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like what we agreed on.

@fstagni fstagni merged commit 178e0c0 into DIRACGrid:rel-v8r0 Oct 20, 2023
20 checks passed
@DIRACGridBot DIRACGridBot added the sweep:done All sweeping actions have been done for this PR label Oct 20, 2023
DIRACGridBot pushed a commit to DIRACGridBot/DIRAC that referenced this pull request Oct 20, 2023
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/6582727808

Successful:

  • integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants