Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] feat (TransformationCleaningAgent): chunk the file removals #7184

Merged
merged 1 commit into from
Sep 15, 2023
Merged

[8.0] feat (TransformationCleaningAgent): chunk the file removals #7184

merged 1 commit into from
Sep 15, 2023

Conversation

chaen
Copy link
Contributor

@chaen chaen commented Aug 30, 2023 •
edited
Loading

For #7183

BEGINRELEASENOTES

*TS
CHANGE: TransformationCleaningAgent removes files by chunk

ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Aug 30, 2023
@andresailer
Copy link
Contributor

What about forwarding the file removal to the RMS?

@chaen
Copy link
Contributor Author

chaen commented Sep 14, 2023

I agree it would be better but probably a bit harder to implement as we need to make sure not to re-send requests from one cycle to the next.
Are you ok with having it merged like this, and we create a task to turn this into requests ?

@andresailer
Copy link
Contributor

Yes, fine to do the changes here.

@chaen chaen mentioned this pull request Sep 15, 2023
Closed
@chaen chaen marked this pull request as ready for review September 15, 2023 08:24
@chaen chaen requested a review from fstagni as a code owner September 15, 2023 08:24
@andresailer andresailer changed the title feat (TransformationCleaningAgent): chunk the file removals [8.0] feat (TransformationCleaningAgent): chunk the file removals Sep 15, 2023
@fstagni fstagni merged commit b37a838 into DIRACGrid:rel-v8r0 Sep 15, 2023
@DIRACGridBot DIRACGridBot added the sweep:done All sweeping actions have been done for this PR label Sep 15, 2023
DIRACGridBot pushed a commit to DIRACGridBot/DIRAC that referenced this pull request Sep 15, 2023
@chaen @web-flow
sweep: DIRACGrid#7184 feat (TransformationCleaningAgent): chunk the f…
0332da8 
…ile removals
@DIRACGridBot DIRACGridBot mentioned this pull request Sep 15, 2023
Merged
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/6196287222

Successful:

  • integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer approved these changes

@fstagni fstagni fstagni approved these changes

Assignees
No one assigned
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chaen @andresailer @DIRACGridBot @fstagni