[8.0] Pilot stamps available in the pilot execution environment #6405
Conversation
DIRACGridBot
added
the
alsoTargeting:integration
|
Hi, I'm not sure the cloud changes will work quite correctly: The pilot/inst UUID is just a random value generated by the cloud provider used as the pilotReference, it doesn't connect back to the instRandom which is only currently included in the instance name. (The return statement from the end of submitPilot has also gone missing). It is possible to get the name from inside the VM, but I think it's probably safer (more portable to different cloud providers) to substitute it directly into the metadata, something like this: Regards, |
|
Thanks Simon, I have included your proposed changes |
|
Hi, |
| @@ -256,6 +256,7 @@ def _writeXRSL(self, executableFile, inputs=None, outputs=None, executables=None | |||
| (inputFiles=({executable} "{executableFile}") {xrslInputAdditions}) | |||
| (stdout="{diracStamp}.out") | |||
| (stderr="{diracStamp}.err") | |||
| (environment="(DIRAC_PILOT_STAMP {diracStamp}")) | |||
There was a problem hiding this comment.
Janusz has been testing this and it seems this line is causing submission errors; should it be:
(environment=("DIRAC_PILOT_STAMP {diracStamp}")) (e.g. with the bracket outside of the string after the equals)?
There was a problem hiding this comment.
Hmm, my previous suggestion isn't quite right... The key and value should also be quoted independently:
(environment=("DIRAC_PILOT_STAMP" "{diracStamp}"))
There was a problem hiding this comment.
I can confirm that the submission to ARC CE works now when setting:
(environment=("DIRAC_PILOT_STAMP" "{diracStamp}"))
|
No extra intervention needed for AREXCE. Please, review |
|
I just reviewed the PR: it looks OK to me, I have nothing to report. |
DIRACGridBot
added
the
sweep:done
|
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/4185234036 Successful:
|
This PR is for passing pilot stamps to the pilot execution environment. This should be done differently for different ComputingElements.
BEGINRELEASENOTES
*Resources
NEW: [ALL]ComputingElements - pass pilot stamp to the pilot environment
ENDRELEASENOTES