test: update to pylint 3.0.0

DIRACGrid · Oct 3, 2023 · 96b5edf · 96b5edf
1 parent 0141194
commit 96b5edf
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/...IRAC/DataManagementSystem/DB/FileCatalogComponents/DirectoryMetadata/DirectoryMetadata.py b/...IRAC/DataManagementSystem/DB/FileCatalogComponents/DirectoryMetadata/DirectoryMetadata.py
@@ -350,11 +350,8 @@ def getDirectoryMetaParameters(self, dpath, credDict, inherited=True):
             return S_OK({})
         metaDict = {}
         for _dID, key, value in result["Value"]:
-            if key in metaDict:
-                if isinstance(metaDict[key], list):
-                    metaDict[key].append(value)
-                else:
-                    metaDict[key] = [metaDict[key]].append(value)
+            if isinstance(metaDict.get(key), list):
+                metaDict[key].append(value)
             else:
                 metaDict[key] = value
 

diff --git a/src/DIRAC/DataManagementSystem/DB/FileCatalogComponents/FileMetadata/FileMetadata.py b/src/DIRAC/DataManagementSystem/DB/FileCatalogComponents/FileMetadata/FileMetadata.py
@@ -358,11 +358,8 @@ def __getFileMetaParameters(self, fileID, credDict):
             return S_OK({})
         metaDict = {}
         for fileID, key, value in result["Value"]:
-            if key in metaDict:
-                if isinstance(metaDict[key], list):
-                    metaDict[key].append(value)
-                else:
-                    metaDict[key] = [metaDict[key]].append(value)
+            if isinstance(metaDict.get(key), list):
+                metaDict[key].append(value)
             else:
                 metaDict[key] = value
 

diff --git a/src/DIRAC/ResourceStatusSystem/scripts/dirac_rss_query_dtcache.py b/src/DIRAC/ResourceStatusSystem/scripts/dirac_rss_query_dtcache.py
@@ -43,10 +43,12 @@ def parseSwitches():
     args = Script.getPositionalArgs()
     if not args:
         error("Missing mandatory 'query' argument")
+        DIRACExit(1)
     elif not args[0].lower() in ("select", "add", "delete"):
         error("Missing mandatory argument")
-    else:
-        query = args[0].lower()
+        DIRACExit(1)
+
+    query = args[0].lower()
 
     switches = dict(Script.getUnprocessedSwitches())