gRPC create #19
Open
gRPC create #19
+221
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elffjs
commented
Oct 15, 2024
| @@ -5,21 +5,15 @@ option go_package = "github.com/DIMO-Network/attestation-api/pkg/grpc"; | |||
| package grpc; | |||
|
|
|||
| service AttestationService { | |||
| rpc BatchCreateVINVC(BatchCreateVINVCRequest) returns (BatchCreateVINVCResponse); | |||
There was a problem hiding this comment.
I guess Yev wants to start with non-batch. Casing looks a bit odd but follows the official style guide.
elffjs
commented
Oct 15, 2024
| message BatchCreateVINVCResponse { | ||
| repeated VINVCResult results = 1; | ||
| message CreateVinVcResponse { | ||
| string raw_vc = 1; |
There was a problem hiding this comment.
Just returning the raw string. I don't really want to build another RPC call into Telemetry. We'll get rid of all this soon.
|
Up to you but I don't mind updating the identity client error handling in this PR. Since this repo is still newer all the updates are welcome |
KevinJoiner
approved these changes
Oct 23, 2024
|
I need to add the actual wiring. This is getting pushed back so I’ll probably just merge in whatever you’re doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a VIN VC retrieval/generation gRPC call for internal use.
forceboolean.