Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests on main are failing #155

Closed
HarmvZ opened this issue Mar 5, 2024 · 4 comments · Fixed by #159
Closed

Tests on main are failing #155

HarmvZ opened this issue Mar 5, 2024 · 4 comments · Fixed by #159
Assignees

Comments

@HarmvZ
Copy link
Member

HarmvZ commented Mar 5, 2024

Integration tests are failing.

tests/test_models.py ......                                                                                     [  4%]
tests/test_async_transports.py ....                                                                             [  7%]
tests/async_client_hybrid_tests.py ...                                                                          [  9%]
tests/test_retries.py ........                                                                                  [ 15%]
tests/integration_tests.py EEEEEEEEEEEEEEEEEEEEEE.EEEEEEEEEEEEEEEE                                              [ 43%]
tests/async_integration_tests.py EEEEEEEEEEEEEEEEEEEEEEEEE.EEEEEEEEEEEEE                                        [ 71%]
tests/test_transports.py ....                                                                                   [ 74%]
tests/test_gcapi.py ...................................                                                         [100%]

Seemingly something is going wrong with creation of the development fixtures of GC. I think this is the cause:

Traceback (most recent call last):
  File "/opt/poetry/.venv/lib/python3.11/site-packages/django_extensions/management/commands/runscript.py", line 204, in my_import
    t = importlib.import_module(full_module_path)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/app/scripts/development_fixtures.py", line 15, in <module>
    from faker import Faker
ModuleNotFoundError: No module named 'faker'
CommandError: An error has occurred running scripts. See errors above.
make: *** [Makefile:101: development_fixtures] Error 1
@jmsmkn
Copy link
Member

jmsmkn commented Aug 2, 2024

TODO:

  • regenerate models.py, currently get a cryptic error: KeyError: '../../../../../../private/var/folders/2p/gx0hvvmd5hv9rw3z82ykqkk40000gn/T/gcapi_modelgen_3nk2kn9s/schema.json#/components/schemas/ArchiveItem/hanging_protocol#-datamodel-code-generator-#-allOf-#-special-#' and the python version needs to be updated to PY_39.
  • Create issue for test reintroduction Add back removed job and archive item tests #161
  • run the tests on main periodically

@jmsmkn
Copy link
Member

jmsmkn commented Aug 7, 2024

Going to have a go at updating the models now.

jmsmkn added a commit to comic/grand-challenge.org that referenced this issue Aug 7, 2024
jmsmkn added a commit to comic/grand-challenge.org that referenced this issue Aug 7, 2024
@jmsmkn
Copy link
Member

jmsmkn commented Aug 7, 2024

The model generation is fixed. Going to deploy GC with the latest models first before making a PR.

@jmsmkn
Copy link
Member

jmsmkn commented Aug 7, 2024

hahaha the tests on main are broken again, already!

@jmsmkn jmsmkn self-assigned this Aug 7, 2024
jmsmkn added a commit that referenced this issue Aug 7, 2024
Also fixes the tests for the latest changes to grand challenge.

Closes #155
chrisvanrun pushed a commit that referenced this issue Nov 5, 2024
Also fixes the tests for the latest changes to grand challenge.

Closes #155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants