Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up unnecessary ModuleSRC files #1711

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Cleaning up unnecessary ModuleSRC files #1711

merged 2 commits into from
Nov 20, 2023

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Nov 20, 2023 •
edited
Loading

PR Description

This should fix some cmake issues.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

@kerautret
Copy link
Member

Thanks ! That looks to gives issues in some situation (one people contact me yesterday :)è

kerautret
kerautret approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine! thanks ;)

@dcoeurjo dcoeurjo merged commit f5451d3 into master Nov 20, 2023
21 of 22 checks passed
@dcoeurjo dcoeurjo deleted the FileExt branch November 20, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerautret kerautret kerautret approved these changes

Assignees

@kerautret kerautret

Labels
ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoeurjo @kerautret