Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in SurfaceMeshWriter::writeIsoLinesOBJ #1701

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Fix typo in SurfaceMeshWriter::writeIsoLinesOBJ #1701

merged 2 commits into from
Aug 16, 2023

Conversation

JacquesOlivierLachaud
Copy link
Member

@JacquesOlivierLachaud JacquesOlivierLachaud commented Aug 14, 2023 •
edited
Loading

PR Description

When outputting several isolines on a SurfaceMesh with method SurfaceMeshWriter::writeIsoLinesOBJ, the isolines were only partially outputted. The problem was the reuse of an outer variable loop in an inner loop. The fix has been checked in an external project.

Checklist

  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions & appveyor)

dcoeurjo
dcoeurjo approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dcoeurjo dcoeurjo merged commit ed2c9b9 into DGtal-team:master Aug 16, 2023
22 checks passed
@dcoeurjo dcoeurjo deleted the FixIsolines branch August 16, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoeurjo dcoeurjo dcoeurjo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JacquesOlivierLachaud @dcoeurjo