Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling ~~c++14~~ c++17 #1682

Merged
merged 11 commits into from
Mar 4, 2023
Merged

Enabling ~~c++14~~ c++17 #1682

merged 11 commits into from
Mar 4, 2023

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Jan 31, 2023 •
edited
Loading

PR Description

Enabling c++14 c++17 in DGtal

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions & appveyor)

@dcoeurjo
Copy link
Member Author

/fullbuild

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Feb 1, 2023

/builddoc

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-nightly/pr1682/index.html

@dcoeurjo dcoeurjo marked this pull request as ready for review February 1, 2023 19:27
@dcoeurjo dcoeurjo changed the title Enabling c++14 Enabling ~~c++14~~ c++17 Feb 8, 2023
dcoeurjo
dcoeurjo commented Feb 8, 2023
View reviewed changes
Copy link
Member Author

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing 17

ChangeLog.md Outdated Show resolved Hide resolved
cmake/Common.cmake Outdated Show resolved Hide resolved
src/DGtal/doc/moduleBuildDGtal.dox Outdated Show resolved Hide resolved
@dcoeurjo
Copy link
Member Author

dcoeurjo commented Feb 8, 2023

/fullbuild

kerautret
kerautret approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@kerautret kerautret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 (I will update the DGtalTools)

@kerautret
Copy link
Member

@dcoeurjo I tried some update to pass C++17 but still some issues due to QGLViewer, I tried to fix it but not success. I have put an issue here when that should be fine to update I think..

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Mar 4, 2023

Ok I see the issue on windows. Let's merge this PR anyway. LibQGLViewer bug is not really related to DGtal.

@dcoeurjo dcoeurjo merged commit fa353ad into master Mar 4, 2023
@dcoeurjo dcoeurjo deleted the Cpp14 branch March 4, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerautret kerautret kerautret approved these changes

Assignees
No one assigned
Labels
Base Build ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoeurjo @kerautret