Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing ImageSelector for faster build (ITK) #1680

Merged
merged 9 commits into from
Feb 16, 2023
Merged

Removing ImageSelector for faster build (ITK) #1680

merged 9 commits into from
Feb 16, 2023

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Jan 9, 2023 •
edited
Loading

PR Description

ImageSelector was included in Surfaces.ih, which leads to slow build time, especially when ITK is enabled.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions & appveyor)

@dcoeurjo dcoeurjo marked this pull request as ready for review January 9, 2023 14:47
@kerautret
Copy link
Member

Thanks, fine for me I just updated from the master and fix the conflict

@dcoeurjo dcoeurjo merged commit 27e5d98 into master Feb 16, 2023
@dcoeurjo dcoeurjo deleted the FastBuild branch February 16, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerautret kerautret kerautret approved these changes

Assignees
No one assigned
Labels
Build ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoeurjo @kerautret