Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing file #1678

Merged

Conversation

JacquesOlivierLachaud
Copy link
Member

@JacquesOlivierLachaud JacquesOlivierLachaud commented Jan 4, 2023

PR Description

Fix issue #1675

Checklist

  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions & appveyor)

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, just few comments.

examples/polyscope-examples/SymmetricConvexExpander.h Outdated Show resolved Hide resolved
examples/polyscope-examples/SymmetricConvexExpander.h Outdated Show resolved Hide resolved
@JacquesOlivierLachaud
Copy link
Member Author

It is completely a work in progress, related to maximal tangent planes. It lays here just to make easier its compilation (it was waiting for inclusion of PR on full convexity).

@dcoeurjo
Copy link
Member

dcoeurjo commented Jan 4, 2023

#1674 fixes the python test issues

@dcoeurjo
Copy link
Member

dcoeurjo commented Jan 6, 2023

/builddoc

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-nightly/pr1678/index.html

@dcoeurjo
Copy link
Member

dcoeurjo commented Jan 6, 2023

/fullbuild

5 similar comments
@dcoeurjo
Copy link
Member

dcoeurjo commented Jan 6, 2023

/fullbuild

@dcoeurjo
Copy link
Member

dcoeurjo commented Jan 9, 2023

/fullbuild

@dcoeurjo
Copy link
Member

dcoeurjo commented Jan 9, 2023

/fullbuild

@dcoeurjo
Copy link
Member

dcoeurjo commented Jan 9, 2023

/fullbuild

@dcoeurjo
Copy link
Member

dcoeurjo commented Jan 9, 2023

/fullbuild

@JacquesOlivierLachaud
Copy link
Member Author

Self merging.

@JacquesOlivierLachaud JacquesOlivierLachaud merged commit d5f6359 into DGtal-team:master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants