Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit config #85

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

pre-commit config #85

wants to merge 3 commits into from

Conversation

lethosor
Copy link
Member

@lethosor lethosor commented Apr 7, 2022

This is currently failing because several XML files are invalid because they have multiple top-level elements:

resources/buildings/caravan_1.xml: Failed to xml parse (resources/buildings/caravan_1.xml:6:0: junk after document element)
resources/terrain/DF_2014_Trees/base_trees_trunk.xml: Failed to xml parse (resources/terrain/DF_2014_Trees/base_trees_trunk.xml:98:0: junk after document element)
resources/terrain/Test.xml: Failed to xml parse (resources/terrain/Test.xml:60:0: junk after document element)
resources/terrain/DF_2014_Trees/base_trees_foliage.xml: Failed to xml parse (resources/terrain/DF_2014_Trees/base_trees_foliage.xml:57:0: junk after document element)
resources/terrain/block_walls.xml: Failed to xml parse (resources/terrain/block_walls.xml:36:0: junk after document element)
resources/terrain/DF_2014_Trees/base_mushroom.xml: Failed to xml parse (resources/terrain/DF_2014_Trees/base_mushroom.xml:83:0: junk after document element)

The two best paths forward I see here are

  • ignoring these files entirely
  • adjusting the parser to accept a parent element enclosing the problematic elements

lethosor added 2 commits April 6, 2022 22:20
@lethosor
Format and fix XML so pre-commit's check-xml can run
a7dd9dd 
tidy -xml -indent --indent-spaces 4 --wrap 0 -modify $(find resources/ -name '*.xml')
@lethosor
Add initial pre-commit config
5245e34
@lethosor lethosor changed the title Draft: pre-commit config pre-commit config Apr 7, 2022
@lethosor lethosor marked this pull request as draft April 7, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
CI
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lethosor