Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to DfE:Analytics verions that fixes remote IP #4830

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asatwal
Copy link
Contributor

@asatwal asatwal commented Nov 25, 2024

Context

Test for DfE:Analytics fix: DFE-Digital/dfe-analytics#175

Trello: https://trello.com/c/HWeQ9OPh

Changes proposed in this pull request

Test only

Guidance to review

Important business

  • Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
  • Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
  • Do we need to send any updates to DQT as part of the work in this PR?
  • Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

@asatwal asatwal added DO NOT MERGE Things could break if this gets merged deploy labels Nov 25, 2024
@asatwal asatwal self-assigned this Nov 25, 2024
Copy link

sonarcloud bot commented Nov 25, 2024

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (3466ece) to head (c55fe10).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4830   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files         726      728    +2     
  Lines       15794    15811   +17     
=======================================
+ Hits        15163    15180   +17     
  Misses        631      631           
Flag Coverage Δ
unittests 96.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy DO NOT MERGE Things could break if this gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant