School user -> refactor remove and view provider specs #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor school user removes provider spec - Refactor school user view empty provider list spec - Remove school user view show page spec due to duplication
dp-daly
changed the title
Kizr
requested changes
Nov 26, 2024
spec/system/placements/schools/partner_providers/remove_a_provider_spec.rb
Outdated
Show resolved
Hide resolved
spec/system/placements/schools/partner_providers/remove_a_provider_spec.rb
Outdated
Show resolved
Hide resolved
spec/system/placements/schools/partner_providers/remove_a_provider_spec.rb
Outdated
Show resolved
Hide resolved
spec/system/placements/schools/partner_providers/remove_a_provider_spec.rb
Outdated
Show resolved
Hide resolved
spec/system/placements/schools/partner_providers/remove_a_provider_spec.rb
Show resolved
Hide resolved
spec/system/placements/schools/partner_providers/remove_a_provider_spec.rb
Outdated
Show resolved
Hide resolved
spec/system/placements/schools/partner_providers/view_empty_provider_list_spec.rb
Show resolved
Hide resolved
spec/system/placements/schools/partner_providers/view_empty_provider_list_spec.rb
Show resolved
Hide resolved
spec/system/placements/schools/partner_providers/view_empty_provider_list_spec.rb
Outdated
Show resolved
Hide resolved
dp-daly
force-pushed
the
school-user-refactor-view-and-remove-provider-specs
branch
from
d06b4df
to
76a2949
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have agreed as a team that we'd like to pursue a new style of system specs to bring our organically (home baked) system specs in line and identify any gaps in their testing.
Changes proposed in this pull request
spec/support/govuk_component_matchers.rbfileGuidance to review
Link to Trello card
https://trello.com/c/ZU2ak4pn/940-refactor-school-user-view-provider-view-provider-list-and-remove-provider-system-specs