feat: FHB-113 Manage DAC languages #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
StuwiiDev
commented
Nov 19, 2024
StuwiiDev
commented
- Fixed a bug with non JS version not working when you try add a new language
- Updated Non JS & JS version to have index numbers on label and remove button as per AC
- Updated the gulp file to get 'del' package to work
added 5 commits
November 18, 2024 09:58
Update the non javascript wording to include the index number. Also update label text
check error length as some pages direct back to selves without errors, like the languages page.
Fixed an issue where adding a new language in non JS would non hold values correctly when going forward/backwards in journey.
Updated the Remove buttons to include an index number for JS rendered. Updated the language labels to include an index number for JS rendered.
StuwiiDev
requested review from
a team,
AaronJY and
Zac-Digital
and removed request for
a team
Zac-Digital
reviewed
Nov 19, 2024
...e-ui/src/FamilyHubs.ServiceDirectory.Admin.Web/Pages/manage-services/What-Language.cshtml.cs
Outdated
Show resolved
Hide resolved
Zac-Digital
reviewed
Nov 19, 2024
...e-ui/src/FamilyHubs.ServiceDirectory.Admin.Web/Pages/manage-services/What-Language.cshtml.cs
Outdated
Show resolved
Hide resolved
Zac-Digital
reviewed
Nov 19, 2024
...e-ui/src/FamilyHubs.ServiceDirectory.Admin.Web/Pages/manage-services/What-Language.cshtml.cs
Outdated
Show resolved
Hide resolved
added 3 commits
November 19, 2024 12:32
Add another method to button removal for readability
Zac-Digital
approved these changes
Nov 19, 2024
AaronJY
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.