Remove leftover TODOs related to testing

DEXPRO-Solutions-GmbH · Feb 2, 2024 · abf163f · abf163f
1 parent a8a6af9
commit abf163f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/r_store_search.go b/r_store_search.go
@@ -90,9 +90,9 @@ type SearchResponseChannel struct {
 	Title        string `xml:"title"`
 	Link         string `xml:"link"`
 	Description  string `xml:"description"`
-	TotalResults int    `xml:"totalResults"` // TODO: Assert in unmarshal test
-	ItemsPerPage int    `xml:"itemsPerPage"` // TODO: Assert in unmarshal test
-	StartIndex   int    `xml:"startIndex"`   // TODO: Assert in unmarshal test
+	TotalResults int    `xml:"totalResults"`
+	ItemsPerPage int    `xml:"itemsPerPage"`
+	StartIndex   int    `xml:"startIndex"`
 	Query        struct {
 		Role        string `xml:"role,attr"`
 		SearchTerms string `xml:"searchTerms,attr"`
@@ -114,10 +114,10 @@ type SearchResponseItem struct {
 	HistoryLink            Link           `xml:"historyLink"`
 	VerifyLink             Link           `xml:"verifyLink"`
 	DocumentType           string         `xml:"documentType"`
-	Fields                 []*RecordField `xml:"field"` // TODO: Assert and check in get attachment response if this is the correct way to handle recurring fields
+	Fields                 []*RecordField `xml:"field"`
 	MasterId               uuid.UUID      `xml:"masterId"`
 	ArchiveDateTime        time.Time      `xml:"archiveDateTime"`
-	ID                     uuid.UUID      `xml:"id"`
+	Id                     uuid.UUID      `xml:"id"`
 	Version                string         `xml:"version"`
 	ArchiverLogin          string         `xml:"archiverLogin"`
 	Archiver               string         `xml:"archiver"`

diff --git a/r_store_search_test.go b/r_store_search_test.go
@@ -31,6 +31,7 @@ func TestStoreClient_Search(t *testing.T) {
 		// assert search result in general
 		assert.Equal(t, "Amazo*", response.Query.SearchTerms)
 		assert.Greater(t, response.TotalResults, 0)
+		assert.Greater(t, response.ItemsPerPage, 0)
 		assert.Greater(t, response.EffectiveResults, 0)
 
 		// assert single hit
@@ -55,6 +56,7 @@ func TestStoreClient_Search(t *testing.T) {
 		// assert search result in general
 		assert.Equal(t, "Amazo*", response.Query.SearchTerms)
 		assert.Greater(t, response.TotalResults, 0)
+		assert.Greater(t, response.ItemsPerPage, 0)
 		assert.Greater(t, response.EffectiveResults, 0)
 
 		// assert single hit