Switch to ESM #128
Merged
Switch to ESM #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need the typescript config file? |
flurdy
reviewed
Aug 13, 2024
chotai
force-pushed
the
413968
branch
2 times, most recently
from
ab8b77e
to
fefa574
Compare
feedmypixel
reviewed
Aug 19, 2024
|
Also can you update |
feedmypixel
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
- LGTM - 1 comment about adding a link to the comment I made about the proxy dispatcher use.
- Also not sure if you want to but might be handy to also add these placeholders in - DEFRA/cdp-node-frontend-template@41c05be
- And just to make sure - this builds and runs ok in docker?
src/helpers/ms-graph.js
Outdated
| @@ -49,6 +49,7 @@ const msGraphPlugin = { | |||
| baseUrl: azureClientBaseUrl, | |||
| ...(proxy && { | |||
| fetchOptions: { | |||
| // @ts-expect-error This is not typed | |||
There was a problem hiding this comment.
would be worth adding this link in here - microsoftgraph/msgraph-sdk-javascript#1646 (comment)
|
|
||
| startServer() | ||
| await startServer() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.