Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GRPC.tts(...) Lua API #202

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Add GRPC.tts(...) Lua API #202

merged 3 commits into from
Dec 6, 2022

Conversation

rkusa
Copy link
Collaborator

@rkusa rkusa commented Dec 5, 2022

Add GRPC.tts(ssml, frequency[, options]) Lua API.

Usage: https://github.com/DCS-gRPC/rust-server/tree/tts-lua#lua-api

Example:

GRPC.tts("Hello Pilot!", 251000000, { srsClientName = "Lua" })

The API currently does not provide an means to prevent overlapping transmissions as we don't want to block the mission env when the API is called and because there is no safe way to return the transmission play time back to Lua asynchronously. I'd suggest to solve this via #200 in future.

@rkusa rkusa changed the title Add GRPC.tts(...) Lua API Add GRPC.tts(...) Lua API Dec 5, 2022
protos/dcs/tts/v0/tts.proto Outdated Show resolved Hide resolved
@rkusa rkusa requested a review from rurounijones December 5, 2022 13:03
rurounijones
rurounijones previously approved these changes Dec 6, 2022
Copy link
Contributor

@rurounijones rurounijones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the InputPosition change I think it would be worth noting that this is a backwards incompatible change with quite a wide ranging impact.

@rkusa rkusa merged commit 7fe8d4c into main Dec 6, 2022
@rkusa rkusa deleted the tts-lua branch December 6, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants