Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add remainderWindowOpen to give immediate packets a better chance #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

habazut
Copy link
Contributor

@habazut habazut commented Nov 6, 2021

Pull request so that we do not forget to improve packet handling. Yet untested.

@Asbelos
Copy link
Contributor

Asbelos commented Nov 6, 2021

Window needs to be opened a little earlier otherwise the waveform will start an idle packet before the loop gets the chance to inject a reminder.

@FrightRisk
Copy link
Member

So where does this fit now with the changes that have been made since this was issued?

@Asbelos
Copy link
Contributor

Asbelos commented Mar 6, 2022

Recent changes dont really affect this.
Basically the waveform needs to change slightly to move the preamble to the END of the packet and set a flag indicating that its close to the end of the preamble.
Reminder loop should not schedule a reminder packet unless the flag is set.
Anyone who complains that the preamble should be at the start... isn't thinking hard enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants