Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove discontinuity handling in the callback #94

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

ChrisRackauckas
Copy link
Contributor

since it's just for monitoring, we should disable the extra saving that is occurring with it. By default it does a pre and post save at the callback points in the assumption that it's required for accurately handling the resolution of the discontinuity. But here we don't want that.

since it's just for monitoring, we should disable the extra saving that is occurring with it. By default it does a pre and post save at the callback points in the assumption that it's required for accurately handling the resolution of the discontinuity. But here we don't want that.
@ChrisRackauckas
Copy link
Contributor Author

@joshday is there a way to test the behavior with the callback? None of the test cases have this callback, so I'm not entirely sure where it enters the web service. That said, I am 100% sure this handles the issue.

@joshday
Copy link
Collaborator

joshday commented Jul 18, 2023

The tests that send requests to the running server will hit it.

@joshday
Copy link
Collaborator

joshday commented Jul 18, 2023

You'll see this while running the tests. The callback is calling publish_to_rabbitmq to send data back to the client.

┌ Warning: RabbitMQ disabled - `publish_to_rabbitmq` with content {"iter":1,"params":[0.9999952915229029,5.919145546989561e-7,3.774131629178174e-6,2.0931364205487055e-7,8.067936912130783e-8,6.747733045656112e-8,1.6241788384319312e-9,3.0555809387394606e-12],"id":"sciml-f4162b51-a673-4472-bc4f-55a014c0298f","abserr":1.1498277159670557e-6,"retcode":"Success","time":0.4851521399160408}
└ @ SimulationService ~/github/simulation-service/src/SimulationService.jl:267

@codecov-commenter
Copy link

Codecov Report

Merging #94 (90f74c7) into main (09a3a7d) will decrease coverage by 0.91%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   80.64%   79.74%   -0.91%     
==========================================
  Files           2        2              
  Lines         310      311       +1     
==========================================
- Hits          250      248       -2     
- Misses         60       63       +3     
Impacted Files Coverage Δ
src/operations.jl 89.13% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit 675f453 into main Jul 18, 2023
@ChrisRackauckas ChrisRackauckas deleted the discretecallback branch July 18, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants