Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataset mapping and more #92

Merged
merged 8 commits into from
Jul 18, 2023
Merged

Fix dataset mapping and more #92

merged 8 commits into from
Jul 18, 2023

Conversation

joshday
Copy link
Collaborator

@joshday joshday commented Jul 18, 2023

ChrisRackauckas and others added 6 commits July 18, 2023 10:25
since it's the default now, it's finding new things. Added it to the tests
since NLopt seems to take awhile to get to its maxiters and doesn't early cut
src/operations.jl Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #92 (fcb3acc) into main (a610ecb) will increase coverage by 3.69%.
The diff coverage is 100.00%.

❗ Current head fcb3acc differs from pull request most recent head a34934f. Consider uploading reports for the commit a34934f to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   76.94%   80.64%   +3.69%     
==========================================
  Files           2        2              
  Lines         308      310       +2     
==========================================
+ Hits          237      250      +13     
+ Misses         71       60      -11     
Impacted Files Coverage Δ
src/SimulationService.jl 73.98% <ø> (ø)
src/operations.jl 89.05% <100.00%> (+8.31%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit 09a3a7d into main Jul 18, 2023
@ChrisRackauckas ChrisRackauckas deleted the jd/dev branch July 18, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants